-
Notifications
You must be signed in to change notification settings - Fork 2
provenance creation for snakemake and nextflow workflows #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ion is then performed with a different script, but all tools can be integrated into the same workflow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to what we discusse, I have added a few minor nitpicks for type hints
benchmarks/linear-elastic-plate-with-hole/FEniCS/plateWithHoleSolution.py
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/FEniCS/plateWithHoleSolution.py
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/FEniCS/plateWithHoleSolution.py
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/FEniCS/plateWithHoleSolution.py
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/FEniCS/run_simulation_fenics.py
Outdated
Show resolved
Hide resolved
benchmarks/linear-elastic-plate-with-hole/FEniCS/run_simulation_fenics.py
Outdated
Show resolved
Hide resolved
…outputs and no longer store the summary.h5
…Solution.py update type hints Co-authored-by: Sjard Mathis Rosenbusch <69848361+srosenbu@users.noreply.github.com>
…Solution.py update type hints Co-authored-by: Sjard Mathis Rosenbusch <69848361+srosenbu@users.noreply.github.com>
…Solution.py update type hints Co-authored-by: Sjard Mathis Rosenbusch <69848361+srosenbu@users.noreply.github.com>
…Solution.py update type hints Co-authored-by: Sjard Mathis Rosenbusch <69848361+srosenbu@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good. I just found one name mismatch for the mesh generation environment file, but this is fine to merge
benchmarks/linear-elastic-plate-with-hole/FEniCS/environment_mesh.yml
Outdated
Show resolved
Hide resolved
…esh.yml Co-authored-by: Sjard Mathis Rosenbusch <69848361+srosenbu@users.noreply.github.com>
Restructure the Snakefile for the linear elastic plate with a hole test |
No description provided.