Minor changes to portal linking #2721
Merged
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tastybento
approved these changes
Aug 16, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Included the border between islands in the portal search range, as currently portals at the edge of an islands protection range dont link to anything. This shouldnt cause any problems as there shouldnt be any portals inbetween islands.
Also uses the portal-search-radius config variable as that seems more intuitive.
This is a bit of a band-aid solution, with a bit of luck in the future PaperMC/Paper#12968 can be used instead of this weird island edge, edge case.
Should resolve #2717 and #2716