Skip to content

Fix sorting by value in details panel #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 16, 2025
+4 −11
Merged

Fix sorting by value in details panel #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1a3a6c2
Fix sorting by value in details panel
PapiCapi Aug 16, 2025
7e66ebd
Remove debug messages
PapiCapi Aug 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/world/bentobox/level/config/BlockConfig.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public BlockConfig(Level addon, YamlConfiguration blockValuesConfig, File file)
// Validate
if (isMaterial(key) || isSpawner(key) || isOther(key)) {
// Store for lookup
this.blockValues.put(key, blocks.getInt(key));
this.blockValues.put(key.toLowerCase(Locale.ENGLISH), blocks.getInt(key));
} else {
addon.logError("Unknown listing in blocks section: " + key);
}
Expand Down
13 changes: 3 additions & 10 deletions src/main/java/world/bentobox/level/panels/DetailsPanel.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,7 @@
package world.bentobox.level.panels;

import java.io.File;
import java.util.ArrayList;
import java.util.Comparator;
import java.util.EnumMap;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import java.util.Objects;
import java.util.Optional;
import java.util.*;
import java.util.stream.Collectors;

import org.bukkit.Material;
Expand Down Expand Up @@ -286,9 +279,9 @@ private void updateFilters() {
int o2Count = blockLimit > 0 ? Math.min(o2.value(), blockLimit) : o2.value();

long o1Value = (long) o1Count
* this.addon.getBlockConfig().getBlockValues().getOrDefault(o1.key(), 0);
* this.addon.getBlockConfig().getBlockValues().getOrDefault(o1.key().toString().toLowerCase(Locale.ENGLISH), 0);
long o2Value = (long) o2Count
* this.addon.getBlockConfig().getBlockValues().getOrDefault(o2.key(), 0);
* this.addon.getBlockConfig().getBlockValues().getOrDefault(o2.key().toString().toLowerCase(Locale.ENGLISH), 0);

if (o1Value == o2Value) {
String o1Name = Utils.prettifyObject(o1.key(), this.user);
Expand Down
Loading