Cancel Playground Tests #2246
Cancel Playground Tests #2246
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🌿 Preview your docs: https://boundary-preview-d8f8f25d-df61-4978-ab80-b663b9f3f02f.docs.buildwithfern.com |
|
you can delete all the non-wasm stuff for now fyi. Like only push the minimum viable code that's all been tested in the playground. |
|
🌿 Preview your docs: https://boundary-preview-eb234b98-e71c-47a6-9de2-6aea40f969ef.docs.buildwithfern.com |
cg-jl
force-pushed
the
jesus/cancel-playground-tests
branch
from
390aa68 to
6839913
Compare
|
I don't have the energy to review the rest of the canceling logic. I'll have some rest & continue tomorrow. Last push is to keep the changes visible & backed up. Will commit --amend when reviewed. |
|
🌿 Preview your docs: https://boundary-preview-58fef13e-511f-4b05-9940-f49b3a8ee80e.docs.buildwithfern.com |
cg-jl
force-pushed
the
jesus/cancel-playground-tests
branch
from
6839913 to
1ca932e
Compare
|
🌿 Preview your docs: https://boundary-preview-bd6776cd-0457-430e-b9c4-2952756dd61d.docs.buildwithfern.com |
|
Canceling logic is in place, but the current system doesn't work: Calling |
|
🌿 Preview your docs: https://boundary-preview-296ee9ed-e3f4-49cd-935b-652b93fae3b7.docs.buildwithfern.com |
|
🌿 Preview your docs: https://boundary-preview-6ca757b2-1cbf-466e-804e-da278f1ec954.docs.buildwithfern.com |
|
Apparently, cancelling the "joined" request (run_tests) does cancel the future. |
- Add { once: true } to external signal abort listeners in BamlStream
- Add { once: true } to internal abort controller listeners
- Add { once: true } to ReadableStream abort listeners
- Update NextJS API route examples with { once: true }
- Update TypeScript examples with { once: true }
- Update integration tests with { once: true }
This prevents memory leaks by automatically removing event listeners
after they fire once, which is the expected behavior for abort events.
Improves performance and ensures proper resource cleanup in long-running
applications with many concurrent requests.
Verified manually that tests can be run on the extension. No cancellation yet.
cg-jl
force-pushed
the
jesus/cancel-playground-tests
branch
from
7645c7d to
21ba107
Compare
cg-jl
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
cg-jl
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
cg-jl
temporarily deployed
to
boundary-tools-dev
GitHub Actions
Inactive
|
🌿 Preview your docs: https://boundary-preview-586f25bd-5f91-4bdd-9a2a-5f8a310c3dd7.docs.buildwithfern.com |
I'll be implementing WASM functionality for enabling cancellation in the playground on top of #2184. I'm not sure how to proceed afterwards wrt merging, since I'm not going to be doing the rest of the clients for now.
Remaining:
canarypnpm dev:vscode