Skip to content

add option in combine_checkboxes() to paste checkboxes when multiple selected #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 10, 2025

Conversation

d-morrison
Copy link
Contributor

@d-morrison d-morrison commented Jul 4, 2025

Description

Adds an option in combine_checkboxes() to concatenate checkbox values when multiple are selected.
Partially addresses #220; implements concatenation approach but not list-column approach.

Screenshots

Input:

> nonrepeat_data
# A tibble: 3 × 6
  study_id multi___1 multi___2 multi___3 single_checkbox___1 extra_data
     <dbl> <lgl>     <lgl>     <lgl>     <lgl>                    <dbl>
1        1 TRUE      FALSE     FALSE     TRUE                         1
2        2 TRUE      TRUE      FALSE     TRUE                         2
3        3 FALSE     FALSE     FALSE     FALSE                        3

Before:

# A tibble: 3 × 4
  study_id extra_data multi    single_checkbox
     <dbl>      <dbl> <fct>    <fct>          
1        1          1 Red      Green          
2        2          2 Multiple Green          
3        3          3 NA       NA      

After:

# A tibble: 3 × 4
  study_id extra_data multi       single_checkbox
     <dbl>      <dbl> <fct>       <fct>          
1        1          1 Red         Green          
2        2          2 Red, Yellow Green          
3        3          3 NA          NA        

PR Checklist

Before submitting this PR, please check and verify below that the submission meets the below criteria:

  • New/revised functions have associated tests
  • New/revised functions that update downstream outputs have associated static testing files (.RDS) updated under inst/testdata/create_test_data.R
    • not sure if needed?
  • New/revised functions use appropriate naming conventions
  • New/revised functions don't repeat code
  • Code changes are less than 250 lines total
  • Issues linked to the PR using GitHub's list of keywords
  • The appropriate reviewer is assigned to the PR
    • doesn't seem like I can do this?
  • The appropriate developers are assigned to the PR
    • doesn't seem like I can do this?
  • Pre-release package version incremented using usethis::use_version()

Code Review

This section to be used by the reviewer and developers during Code Review after PR submission

Code Review Checklist

  • I checked that new files follow naming conventions and are in the right place
  • I checked that documentation is complete, clear, and without typos
  • I added/edited comments to explain "why" not "how"
  • I checked that all new variable and function names follow naming conventions
  • I checked that new tests have been written for key business logic and/or bugs that this PR fixes
  • I checked that new tests address important edge cases

@d-morrison d-morrison changed the title add option to paste checkboxes when multiple selected add option in combine_checkboxes() to paste checkboxes when multiple selected Jul 4, 2025
@d-morrison d-morrison marked this pull request as ready for review July 4, 2025 20:13
@d-morrison
Copy link
Contributor Author

@rsh52 this PR partially addresses #220; glad to revise as helpful!

@rsh52 rsh52 requested review from ezraporter and rsh52 July 7, 2025 13:11
@rsh52 rsh52 added the enhancement New feature or request label Jul 7, 2025
rsh52 added a commit that referenced this pull request Jul 7, 2025
Refactored #225, moved to new branch to access org secrets to let actions pass. Updated .Rd docs and linting.
@rsh52 rsh52 merged commit 1292ad4 into CHOP-CGTInformatics:main Jul 10, 2025
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants