Skip to content

chore: Fix mypy error on release-check #1065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 22, 2025
Merged

Conversation

aborgna-q
Copy link
Collaborator

@aborgna-q aborgna-q commented Aug 22, 2025

Fixes the CI error seen here
https://github.com/CQCL/tket2/actions/runs/17160316462/job/48687663355?pr=1063#step:7:16

We were also running all the python tests in the repo, and that failed for tket-exts since they assume local breaking changes.

See
#1063

Test run:
https://github.com/CQCL/tket2/actions/runs/17160588994/job/48688591843

@aborgna-q aborgna-q requested a review from a team as a code owner August 22, 2025 16:21
@aborgna-q aborgna-q requested review from lmondada and ss2165 and removed request for lmondada August 22, 2025 16:21
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.98%. Comparing base (a32873e) to head (34daef3).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1065   +/-   ##
=======================================
  Coverage   78.98%   78.98%           
=======================================
  Files         115      115           
  Lines       13389    13389           
  Branches    12607    12607           
=======================================
  Hits        10575    10575           
  Misses       2160     2160           
  Partials      654      654           
Flag Coverage Δ
python 92.83% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aborgna-q aborgna-q added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 9a1b555 Aug 22, 2025
22 checks passed
@aborgna-q aborgna-q deleted the ab/fix-mypy-release-check branch August 22, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants