Skip to content

Feature comms refactor #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 101 commits into from
Apr 27, 2025
Merged

Feature comms refactor #132

merged 101 commits into from
Apr 27, 2025

Conversation

Pandabear1125
Copy link
Contributor

@Pandabear1125 Pandabear1125 commented Apr 12, 2025 •
edited by StudentKyle
Loading

yer

Additional Co-Authors: @StudentKyle
Additional Advisors: @ashleycody345

ashleycody345 and others added 30 commits January 10, 2025 22:08
@ashleycody345
copy paste (mostly) from hive to bring over comms stuff (mostly). doe…
f27ce75 
…s not compile atm
@ashleycody345
added RobotState data, it compiles now WOOOOO
039c946
@ashleycody345
comms_layer.cpp prototype, along with RobotState vector struct templa…
b01360e 
…te for the future
@ashleycody345
minor changes to include CommsLayer in main (can be reverted, just fo…
45cd458 
…r testing atm)
@ashleycody345
integrate comms layer into main loop
c263695
@ashleycody345
why did this work??????
2b180eb
@ashleycody345
Merge remote-tracking branch 'origin/main' into feature-comms-refactor
36e9b8d
@ashleycody345
packet receiving and managing
32fa669
@ashleycody345
missed part of invalid packet function
d2588f7
@ashleycody345
removed EthernetPayload (to be later replaced with internal packet pr…
02bfb2a 
…iority queue)
@ashleycody345
Merge remote-tracking branch 'origin/feature-hot-reload' into feature…
55a20c2 
…-comms-refactor
@ashleycody345
Merge remote-tracking branch 'origin/main' into feature-comms-refactor
f8457d6
@ashleycody345
Merge remote-tracking branch 'origin/main' into feature-comms-refactor
499969e
@ashleycody345
removed interfacing with old config layer for ethernet config
e99cc96
@ashleycody345
renaming and changing types of misc
abd9dd3
@ashleycody345
Merge remote-tracking branch 'origin/main' into feature-comms-refactor
b117160
@ashleycody345
ngl i dont really rememebr skull ejomi
f5a2a2c
@ashleycody345
cleanup for my own sanity
a4de226
@ashleycody345
defined send, receive, loop functions
b05df9c
@ashleycody345
very simple encode
3f23541
@ashleycody345
prototype send and receive for toy string struct
8ef72ba
@ashleycody345
comms layer can send stuff now (!!!)
2cf31cf
@ashleycody345
Merge remote-tracking branch 'origin/main' into feature-comms-refactor
a787cc2
@ashleycody345
move over everything from hive (big commit sorry)
bc700e0
@ashleycody345
sample data is sent correctly WOOOOOO
5b10075
@ashleycody345
trying to fix the send errors
b2ba351
@Pandabear1125
changes
90f1f19
@Pandabear1125
Fresh slate
cfe055b
@Pandabear1125
Merged config updates from main. Adds a timeout for ethernet warmup
d838e29
@Pandabear1125
Adds hive's comms stuff
3b95cd8
@Pandabear1125 Pandabear1125 requested a review from Rishi-H April 12, 2025 05:28
@Pandabear1125 Pandabear1125 self-assigned this Apr 12, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 12, 2025 •
edited
Loading

Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging.

Pandabear1125
Pandabear1125 commented Apr 12, 2025
View reviewed changes
Rishi-H
Rishi-H requested changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@Rishi-H Rishi-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few minor requests

@Pandabear1125 Pandabear1125 requested a review from Rishi-H April 23, 2025 01:05
Rishi-H
Rishi-H approved these changes Apr 23, 2025
View reviewed changes
Copy link
Contributor

@Rishi-H Rishi-H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@StudentKyle
Copy link
Contributor

Review published on sister PR in Hive

@StudentKyle
Copy link
Contributor

Reviews passed, and final tests on robot all good!

@StudentKyle StudentKyle merged commit 6c21305 into main Apr 27, 2025
2 checks passed
@Pandabear1125 Pandabear1125 deleted the feature-comms-refactor branch April 27, 2025 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rishi-H Rishi-H Rishi-H approved these changes

Assignees

@StudentKyle StudentKyle

@Pandabear1125 Pandabear1125

@ashleycody345 ashleycody345

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Pandabear1125 @StudentKyle @Rishi-H @ashleycody345 @guywithhat99 @cu-boulder-robotics