-
Notifications
You must be signed in to change notification settings - Fork 1
Adds library source back and adds SD card library #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
13215969 | Triggered | Generic Password | 08f9444 | teensy4/usb.c | View secret |
13215969 | Triggered | Generic Password | 08f9444 | teensy4/usb.c | View secret |
13215969 | Triggered | Generic Password | 08f9444 | teensy4/usb.c | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Unified packet sizes just in case we define USB_EVERYTHING in the future
GitGuardian's warning apears to be a false positive. I could not see anything in usb.h that would be a secret. (we also dont use API keys lol). This code comes straight from paul anyway |
I'll be testing this to verify robot stability later today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good. Hopefully the git guardian doesn't comment on every PR going forward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test PR on robot
Tested, works |
Marked security issue as false positive because it is a false positive within the teensy lib |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Robot moved and hive started and worked
Title. Also: