Skip to content

Adds library source back and adds SD card library #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Aug 22, 2024
Merged

Conversation

Pandabear1125
Copy link
Contributor

Title. Also:

  • Makefile is updated to allow rebuilding libraries
  • I modified the Teensy's core library's printf function to work regardless of various compiler flags
  • Edited FS.h to accommodate the SD library
  • Added TimeLib library by paul: https://github.com/PaulStoffregen/Time

@Pandabear1125 Pandabear1125 self-assigned this Jul 29, 2024
Copy link

Doxygen warnings output: (if empty, there are no warnings). Please correct any warnings before merging.

  

Copy link

gitguardian bot commented Jul 29, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
13215969 Triggered Generic Password 08f9444 teensy4/usb.c View secret
13215969 Triggered Generic Password 08f9444 teensy4/usb.c View secret
13215969 Triggered Generic Password 08f9444 teensy4/usb.c View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Unified packet sizes just in case we define USB_EVERYTHING in the future
@Pandabear1125
Copy link
Contributor Author

GitGuardian's warning apears to be a false positive. I could not see anything in usb.h that would be a secret. (we also dont use API keys lol). This code comes straight from paul anyway

@Pandabear1125
Copy link
Contributor Author

I'll be testing this to verify robot stability later today

Copy link
Contributor

@StudentKyle StudentKyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. Hopefully the git guardian doesn't comment on every PR going forward.

@StudentKyle StudentKyle self-requested a review August 6, 2024 00:16
Copy link
Contributor

@StudentKyle StudentKyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test PR on robot

@Pandabear1125
Copy link
Contributor Author

Tested, works

@StudentKyle
Copy link
Contributor

Marked security issue as false positive because it is a false positive within the teensy lib

@StudentKyle StudentKyle self-requested a review August 22, 2024 21:20
Copy link
Contributor

@StudentKyle StudentKyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Robot moved and hive started and worked

@StudentKyle StudentKyle merged commit 69f82c6 into main Aug 22, 2024
2 checks passed
@Pandabear1125 Pandabear1125 deleted the feature-SD-lib branch August 22, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants