Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

Optimize/scalar multiplication #79

Merged
merged 12 commits into from
Mar 4, 2025
Merged

Conversation

fbielejec
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Mar 3, 2025

Circuit Metric Main branch New code % Change
New account k $${\color{red}11}$$ $${\color{green}10}$$ $${\color{green}-9.09\%}$$
New account max_advice_rows $${\color{red}1898}$$ $${\color{green}701}$$ $${\color{green}-63.07\%}$$
New account max_fixed_rows $${\color{green}210}$$ $${\color{red}645}$$ $${\color{red}207.14\%}$$
New account max_rows $${\color{red}1898}$$ $${\color{green}701}$$ $${\color{green}-63.07\%}$$
New account proving key size $${\color{red}21.2 MB}$$ $${\color{green}10.6 MB}$$ $${\color{green}-50.00\%}$$
New account verification key size $${\color{red}3.3 KB}$$ $${\color{green}2.1 KB}$$ $${\color{green}-36.36\%}$$

@fbielejec fbielejec requested a review from pmikolajczyk41 March 3, 2025 21:06
})
.is_err());
}

// #[test]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leftover

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my bad, we can keep this test. Fixed

@fbielejec fbielejec requested a review from pmikolajczyk41 March 4, 2025 12:28
@fbielejec fbielejec merged commit 9b63be7 into main Mar 4, 2025
5 checks passed
@fbielejec fbielejec deleted the optimize/scalar-multiplication branch March 4, 2025 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants