Skip to content
This repository was archived by the owner on Aug 5, 2025. It is now read-only.

PoW gone. #83

Merged
merged 11 commits into from
Mar 5, 2025
Merged

PoW gone. #83

merged 11 commits into from
Mar 5, 2025

Conversation

DamianStraszak
Copy link
Contributor

Removed the remaining traces of ID-HIDING.

Updated toolchain.

A few clippy changes resulting from toolchain bump.

@@ -58,14 +58,14 @@ impl NewAccountChip {
)
}

pub fn constrain_hashed_id(
pub fn constrain_prenullifier(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe a comment for why this constraint is needed pls 🙇

Copy link
Contributor

@fbielejec fbielejec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, can be merged once we fix the CI problems

Copy link

github-actions bot commented Mar 5, 2025

Circuit Metric Main branch New code % Change
Deposit advice_queries $${\color{red}26}$$ $${\color{green}25}$$ $${\color{green}-3.85\%}$$
Deposit fixed_queries $${\color{red}14}$$ $${\color{green}12}$$ $${\color{green}-14.29\%}$$
Deposit lookups $${\color{red}1}$$ $${\color{green}0}$$ $${\color{green}-100.00\%}$$
Deposit max_advice_rows $${\color{red}864}$$ $${\color{green}785}$$ $${\color{green}-9.14\%}$$
Deposit max_fixed_rows $${\color{red}864}$$ $${\color{green}785}$$ $${\color{green}-9.14\%}$$
Deposit max_rows $${\color{red}864}$$ $${\color{green}785}$$ $${\color{green}-9.14\%}$$
Deposit num_fixed_columns $${\color{red}14}$$ $${\color{green}12}$$ $${\color{green}-14.29\%}$$
Deposit num_total_columns $${\color{red}24}$$ $${\color{green}22}$$ $${\color{green}-8.33\%}$$
Deposit proof size $${\color{red}3.9 KB}$$ $${\color{green}3.5 KB}$$ $${\color{green}-10.26\%}$$
Deposit proving key size $${\color{red}11.3 MB}$$ $${\color{green}10.6 MB}$$ $${\color{green}-6.19\%}$$
Deposit verification key size $${\color{red}1.9 KB}$$ $${\color{green}1.7 KB}$$ $${\color{green}-10.53\%}$$
Withdraw max_advice_rows $${\color{red}868}$$ $${\color{green}790}$$ $${\color{green}-8.99\%}$$
Withdraw max_fixed_rows $${\color{red}868}$$ $${\color{green}790}$$ $${\color{green}-8.99\%}$$
Withdraw max_rows $${\color{red}868}$$ $${\color{green}790}$$ $${\color{green}-8.99\%}$$

@DamianStraszak DamianStraszak merged commit 804c057 into main Mar 5, 2025
5 checks passed
@DamianStraszak DamianStraszak deleted the remove-pow-revoking branch March 5, 2025 14:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants