add service file support for gravyvalet addon service #2609
+227
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@futa-ikeda Could you help review my changes and let me know if anything needs improvement? |
futa-ikeda
approved these changes
Aug 14, 2025
|
Looks good to me, although it's been a while since I've looked through this file. Appreciate you adding tests to that route too! 🥳 |
futa-ikeda
merged commit a904887
into
CenterForOpenScience:feature/azure-blob-storage
9 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NII Implement file preview functionality in ember-osf-web
#51
Purpose
This enables dynamic file handling based on configured external storage services, supporting the gravyvalet addon service file.
Summary of Changes
Screenshot(s)
Side Effects
QA Notes