forked from KhronosGroup/glTF
-
Notifications
You must be signed in to change notification settings - Fork 9
Update KHR_gaussian_splatting and KHR_spz_gaussian_splats_compression extensions in cesium-native branch #86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add link to Chinese version of overview * Link to releases and PDF for overview translations
* Initial draft for KHR_materials_translucency. * Added figure and code to describe BTDF. * Update KHR_materials_translucency - Move info in interaction with other extensions to translucency - Add images - Add more detailed explanation * README.md edited * Change summary images; Add review changes * Change thin transmission image; Fix font * Change summary images; Add review changes * Add translucency color parameter and examples * Optimize example image format/size * Add example description; Update brdf notation * Rename translucency -> diffuse_transmission * Change example table layout, edit descriptions * Update extensions/2.0/Khronos/KHR_materials_diffuse_transmission/schema/glTF.KHR_materials_diffuse_transmission.schema.json Co-authored-by: abwood <abwood@gmail.com> * Remove example for combined diffuse-/transmission Effect not obvious in the image * Remove all references to KHR_materials_sss * Remove extensions combination overview for now Needs better images or renderings * Update image text * Fix typo * Revise spec - Add more detailed parameter descriptions based on PR feedback + renderings - Add dragon and candle renderings as example for diffuse transmission + volume - Remove example section * Fix image table layout. Add white bg to bsdf image for better visibility. * Split up normative "material structure update" and non-normative implementation sections * Fix Appendix B url * Add exclusions; Add scene/texture attribution * Use https uri * Remove leaves image --------- Co-authored-by: SDORRA Bastian <Bastian.SDORRA@3ds.com> Co-authored-by: Bastian Sdorra <bsdorra@gmail.com> Co-authored-by: abwood <abwood@gmail.com> Co-authored-by: Bastian SDORRA <q6q@3ds.com>
* Link cleanup * Update leaf image and captions * Khronos copyright
…or. Also some grammar. (KhronosGroup#2215) * Clarify relationship between `intensity` and `color`. Also fix some pre-existing grammar issues. * Fix subheading hierarchy, and some wording.
Co-authored-by: Adam Morris <adam@kernelpanicstudios.com>
Co-authored-by: Adam Morris <adam@kernelpanicstudios.com>
…e extension rather than building on KHR_gaussian_splatting
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…DME.md Co-authored-by: Sean Lilley <lilleyse@gmail.com>
Co-authored-by: Sean Lilley <lilleyse@gmail.com>
Co-authored-by: Sean Lilley <lilleyse@gmail.com>
…re-index Allow for non-SPZ encoded vertex attributes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brings in the most recent updates and changes including the extension split.