-
Notifications
You must be signed in to change notification settings - Fork 9
Lykhoyda/add snap #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you we going to apply as global lint to the demo-wallet ( and we definitely should, I'm glad you added that) we should also include the .eslint config in that package so everyone's editors will respect the same style.
Other than that and the issue with removing the _headers
file this looks good to merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is used by Netlify (and other web hosting platforms) to set the headers correctly. Please put it back 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@willemolding I will take care of global eslint in the next PR with demo-wallet to configure it for all front-end projects
…package Snap consuming webz-keys without adding extra build stage
I think it's also a good strategy so far to make it more minimalistic as we don't require any customization since we split the wasm packages. I merged your PR and added some adjustments. Please take a look 👍 |
No description provided.