Skip to content

Lykhoyda/add snap #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 6, 2024
Merged

Conversation

Lykhoyda
Copy link
Contributor

No description provided.

@Lykhoyda Lykhoyda marked this pull request as ready for review October 28, 2024 16:14
@Lykhoyda Lykhoyda requested a review from willemolding October 29, 2024 15:32
Copy link
Contributor

@willemolding willemolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you we going to apply as global lint to the demo-wallet ( and we definitely should, I'm glad you added that) we should also include the .eslint config in that package so everyone's editors will respect the same style.

Other than that and the issue with removing the _headers file this looks good to merge

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is used by Netlify (and other web hosting platforms) to set the headers correctly. Please put it back 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willemolding I will take care of global eslint in the next PR with demo-wallet to configure it for all front-end projects

@willemolding
Copy link
Contributor

@willemolding willemolding self-requested a review November 4, 2024 02:45
…package

Snap consuming webz-keys without adding extra build stage
@Lykhoyda
Copy link
Contributor Author

Lykhoyda commented Nov 4, 2024

Please see https://github.com/Lykhoyda/WebZjs/pull/1/files

I think it's also a good strategy so far to make it more minimalistic as we don't require any customization since we split the wasm packages. I merged your PR and added some adjustments. Please take a look 👍

@willemolding willemolding merged commit 4aba26b into ChainSafe:main Nov 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants