Skip to content

Feature: Updating new swift-syntax version to 600.0.1 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

manuelkunzdmde
Copy link

Feature: Updating new swift-syntax version to 600.0.1

Our project relies on other packages which need the new swift-syntax version.
So an update for the new swift-syntax version would be really useful for us.

I updated the version and removed the deprecations which occurred after the update.

@theoriginalbit
Copy link
Collaborator

Thanks for your contribution @manuelkunzdmde!

I'm happy to see this PR merged to support a swift-syntax that can assist with Swift 6 code. It looks as though there may have been some larger changes in 600.0.1 beyond deprecations though as the unit tests are failing.

Are you happy to look into getting those tests passing?

@manuelkunzdmde
Copy link
Author

Not quite sure when I can have a look at it. Quick Look seems like it could be a problem in the swift-syntax lib as well. So I'd appreciate if someone could have look it as well.

@theoriginalbit
Copy link
Collaborator

No worries, I'll try to make some time today to help out

@mobrien-ghost
Copy link
Collaborator

Have put up a PR that addresses the underlying inout token structure/hierarchy changes in a PR here. This also drops swift 5.7 support as the swift-syntax library from the latest version does not support it (and not interested in this library maintaining different swift-syntax versions for different swift language versions)

@manuelkunzdmde
Copy link
Author

Seems we can close this one since the PR mentioned above was merged. Thank u 👍

@mobrien-ghost
Copy link
Collaborator

Latest release (from 5.0.0) has this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants