adds option to overwrite soap attributes key #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edService case without needing to specify attributesKey; Uncommented lines that were required to pass the attribute key.
Testing FeedService functionality; Added automatic handling of the Fe…
profnandaa
reviewed
Sep 26, 2018
readme.md
Outdated
| @@ -39,7 +39,7 @@ const AdwordsUser = require('node-adwords').AdwordsUser; | |||
| const AdwordsConstants = require('node-adwords').AdwordsConstants; | |||
|
|
|||
| let user = new AdwordsUser({...}); | |||
| let campaignService = user.getService('CampaignService', 'v201802') | |||
| let campaignService = user.getService('CampaignService', 'v201806') | |||
There was a problem hiding this comment.
Why don't we get the version from the constants set instead? DEFAULT_ADWORDS_VERSION / So that the README stays the same for the most part.
readme.md
Outdated
| @@ -64,7 +64,7 @@ regular api. | |||
| const AdwordsReport = require('node-adwords').AdwordsReport; | |||
|
|
|||
| let report = new AdwordsReport({/** same config as AdwordsUser above */}); | |||
| report.getReport('v201802', { | |||
| report.getReport('v201806', { | |||
There was a problem hiding this comment.
Same here, get version from DEFAULT_ADWORDS_VERSION
readme.md
Outdated
| @@ -83,7 +83,7 @@ report.getReport('v201802', { | |||
| You can also pass in additional headers in case you need to remove the header rows | |||
|
|
|||
| ```js | |||
| report.getReport('v201802', { | |||
| report.getReport('v201806', { | |||
readme.md
Outdated
| @@ -120,7 +120,7 @@ You can also use AWQL with Performance Reports | |||
|
|
|||
| ```js | |||
| let report = new AdwordsReport({/** same config as AdwordsUser above */}); | |||
| report.getReport('v201802', { | |||
| report.getReport('v201806', { | |||
| @@ -18,7 +18,7 @@ if (developerToken && refreshToken && clientId && clientSecret && clientCustomer | |||
| client_id: clientId, | |||
| client_secret: clientSecret, | |||
| refresh_token: refreshToken, | |||
| version: 'v201802' | |||
| version: 'v201806' | |||
There was a problem hiding this comment.
Same here, get from DEFAULT_ADWORDS_VERSION
|
I have removed the comments but the static versions are not actually part of the code. |
* Updated package dependencies * Added error handling for cases involving requests that do not conform to endpoint WSDL.
Bumps [axios](https://github.com/axios/axios) from 0.18.0 to 0.18.1. - [Release notes](https://github.com/axios/axios/releases) - [Changelog](https://github.com/axios/axios/blob/v0.18.1/CHANGELOG.md) - [Commits](axios/axios@v0.18.0...v0.18.1) --- updated-dependencies: - dependency-name: axios dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.10 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.10...4.17.21) --- updated-dependencies: - dependency-name: lodash dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FeedService asks for a key named attributes, which conflicts with the current code.
Without breaking any compatibility with existing code we added an extra option to set the name of the attributes key by forwarding it to node-soap.