Module: dcnm_vpc_pair - Remove Manageable Check for Devices #345
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikewiebe
changed the title
allenrobel
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dcnm_vpc_pairmodule currently has a check to see if devices are in amanageablestate before attempting to put them into a vpc pair but this check is not needed and in fact breaks pre-provision workflows.A device or switch state can be unmanageable for a variety of reasons but we should not be checking this state to use it for making configuration decisions. A device that is in this state can still be configured as a vpc pair.
Removing this check but leaving the function in the library if we decide we need it down the road for different use cases.