Skip to content

Fix policy delete for freeform deploy false #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 2, 2025
Merged

Fix policy delete for freeform deploy false #403

merged 5 commits into from
May 2, 2025

Conversation

mikewiebe
Copy link
Collaborator

@mikewiebe mikewiebe commented Apr 24, 2025 •
edited
Loading

Fixes #398

Summary of Updates:

  • Fixes problem where deleting a policy with deploy: false marks the policy as deleted but does not delete the configuration from the switch when a deploy is executed (global or switch level)
  • Adds a test playbook to easily run the dcnm_policy integration tests and fixes a few issues with the tests

@mikewiebe mikewiebe added the wip Work In Progress - DO NOT MERGE YET label Apr 24, 2025
@mikewiebe mikewiebe added ready for review PR is ready to be reviewed and removed wip Work In Progress - DO NOT MERGE YET labels Apr 26, 2025
peter8498
peter8498 approved these changes May 2, 2025
View reviewed changes
Copy link
Contributor

@peter8498 peter8498 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good

@mikewiebe mikewiebe merged commit cc8aa44 into develop May 2, 2025
9 checks passed
@mikewiebe mikewiebe deleted the fix_policy_deploy branch July 2, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@peter8498 peter8498 peter8498 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ready for review PR is ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using deploy=false flag on policy deletion fails
2 participants
@mikewiebe @peter8498