-
Notifications
You must be signed in to change notification settings - Fork 46
It dcnm network sanity #418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mikewiebe
merged 17 commits into
CiscoDevNet:develop
from
neiljohn-gh:IT_dcnm_network_sanity
Jun 18, 2025
Merged
It dcnm network sanity #418
mikewiebe
merged 17 commits into
CiscoDevNet:develop
from
neiljohn-gh:IT_dcnm_network_sanity
Jun 18, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…chema and helper functions to compare actual and expected data
…hecks in action plug in, updated schema, updated tags
@neiljohn-gh Thanks for opening the PR! There are some CI errors that need to be resolved (https://github.com/CiscoDevNet/ansible-dcnm/actions/runs/15182282603/job/42694308666?pr=418). Let me know if you have any questions about them. |
Closed
mikewiebe
requested changes
May 28, 2025
mikewiebe
reviewed
May 28, 2025
…d action plugins to make it more readable, finished query and overridden
neiljohn-gh
commented
May 29, 2025
neiljohn-gh
commented
May 29, 2025
…ff. moved templates into separate folders
0667a50
to
3b7b264
Compare
Back from CL and was giving this another review and running the various tests. Looks like there is an issue with the TASK [dcnm_network : MERGED - TC12 - Create Network and deploy in invalid switch] ***************************************************************************
task path: /Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/cisco/dcnm_neil/tests/integration/targets/dcnm_network/tests/dcnm/merged.yaml:811
fatal: [nac-fabric1]: FAILED! => {
"msg": "The task includes an option with an undefined variable.. 'interface_1a' is undefined\n\nThe error appears to be in '/Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/cisco/dcnm_neil/tests/integration/targets/dcnm_network/tests/dcnm/merged.yaml': line 811, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: MERGED - TC12 - Create Network and deploy in invalid switch\n ^ here\n"
}
...ignoring
TASK [dcnm_network : MERGED - TC12 - ASSERT - Check invalid switch] *****************************************************************************************
task path: /Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/cisco/dcnm_neil/tests/integration/targets/dcnm_network/tests/dcnm/merged.yaml:831
Loading collection ansible.utils from /Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/ansible/utils
fatal: [nac-fabric1]: FAILED! => {
"assertion": "\"Invalid parameters in playbook: ip_address : Required parameter not found\" in result.msg",
"changed": false,
"evaluated_to": false,
"msg": "Assertion failed"
}
PLAY RECAP **************************************************************************************************************************************************
nac-fabric1 : ok=122 changed=24 unreachable=0 failed=1 skipped=0 rescued=0 ignored=6 |
mikewiebe
reviewed
Jun 17, 2025
mikewiebe
reviewed
Jun 17, 2025
tests/integration/targets/dcnm_network/templates/self-contained-tests/scale_conf.j2
Outdated
Show resolved
Hide resolved
mikewiebe
approved these changes
Jun 18, 2025
tests/integration/targets/dcnm_network/tests/dcnm/self-contained-tests/replaced_net_all.yaml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored IT: dcnm_network: SANITY and DELETED
Used Pydantic schema and DeepDiff for comparing expected data with ndfc data in the tests.