Skip to content

It dcnm network sanity #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jun 18, 2025

Conversation

neiljohn-gh
Copy link
Collaborator

Refactored IT: dcnm_network: SANITY and DELETED
Used Pydantic schema and DeepDiff for comparing expected data with ndfc data in the tests.

@mikewiebe
Copy link
Collaborator

@neiljohn-gh Thanks for opening the PR! There are some CI errors that need to be resolved (https://github.com/CiscoDevNet/ansible-dcnm/actions/runs/15182282603/job/42694308666?pr=418). Let me know if you have any questions about them.

@mikewiebe mikewiebe mentioned this pull request May 22, 2025
…d action plugins to make it more readable, finished query and overridden
@neiljohn-gh neiljohn-gh force-pushed the IT_dcnm_network_sanity branch from 0667a50 to 3b7b264 Compare June 12, 2025 11:02
@mikewiebe
Copy link
Collaborator

Back from CL and was giving this another review and running the various tests. Looks like there is an issue with the tests/dcnm/merged.yaml test.

TASK [dcnm_network : MERGED - TC12 - Create Network and deploy in invalid switch] ***************************************************************************
task path: /Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/cisco/dcnm_neil/tests/integration/targets/dcnm_network/tests/dcnm/merged.yaml:811
fatal: [nac-fabric1]: FAILED! => {
    "msg": "The task includes an option with an undefined variable.. 'interface_1a' is undefined\n\nThe error appears to be in '/Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/cisco/dcnm_neil/tests/integration/targets/dcnm_network/tests/dcnm/merged.yaml': line 811, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: MERGED - TC12 - Create Network and deploy in invalid switch\n  ^ here\n"
}
...ignoring

TASK [dcnm_network : MERGED - TC12 - ASSERT - Check invalid switch] *****************************************************************************************
task path: /Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/cisco/dcnm_neil/tests/integration/targets/dcnm_network/tests/dcnm/merged.yaml:831
Loading collection ansible.utils from /Users/mwiebe/Projects/Ansible/nac-vxlan/collections/ansible_collections/ansible/utils
fatal: [nac-fabric1]: FAILED! => {
    "assertion": "\"Invalid parameters in playbook: ip_address : Required parameter not found\" in result.msg",
    "changed": false,
    "evaluated_to": false,
    "msg": "Assertion failed"
}

PLAY RECAP **************************************************************************************************************************************************
nac-fabric1                : ok=122  changed=24   unreachable=0    failed=1    skipped=0    rescued=0    ignored=6   

@mikewiebe mikewiebe merged commit ae2b9ce into CiscoDevNet:develop Jun 18, 2025
16 checks passed
@neiljohn-gh neiljohn-gh deleted the IT_dcnm_network_sanity branch July 4, 2025 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants