Skip to content

Access interface parameters #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 22, 2025

Conversation

mkilar123
Copy link
Contributor

This PR fixes:
Fixes #430

This PR is to add parameters allowing the control on enabling three features:

  • CDP
  • PFD
  • Switchport monitor modes

The controls are made available for following interface types:

  • physical ethernet configured as access port,
  • physical ethernet configured as trunk port,
  • non-vpc port-channel configured as access port,
  • non-vpc port-channel configured as trunk port,

The controls are implemented as a simple bolean values.
For the keys used in the module i tried to be consistend with what's currently used:
"ENABLE_PFC": "enable_pfc",
"ENABLE_MONITOR": "enable_monitor",
"CDP_ENABLE": "enable_cdp",

Tested each interface type in the lab specifying the following set of attributes:

  • none of the three controls are defined,
  • all three controls are defined and match the defaults,
  • all three controls are defined and set to values opposite to defaults,
  • only one or two controls are defined.

@mikewiebe
Copy link
Collaborator

mikewiebe commented Jun 19, 2025

@mkilar123 you can run the ansible-sanity tests in your local workspace using the following command instead of making changes to the PR and waiting for me to approve the run

https://github.com/CiscoDevNet/ansible-dcnm/blob/develop/.github/workflows/main.yml#L85

That way you can get the tests passing locally before pushing the changes

@mkilar123
Copy link
Contributor Author

corrected the documentation typos that made the tests fail

@mkilar123 mkilar123 force-pushed the access_interface_parameters branch from c661435 to f9cd2dc Compare June 30, 2025 21:21
@mikewiebe mikewiebe merged commit e103fef into CiscoDevNet:develop Jul 22, 2025
16 checks passed
@mkilar123 mkilar123 deleted the access_interface_parameters branch July 23, 2025 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add control options for enabling CDP/PFC and Monitor mode on physical interfaces (access/trunk) and non-vpc port-channels (access/trunk)
2 participants