Skip to content

changed unpublished endpoints to published ones #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

neiljohn-gh
Copy link
Collaborator

@neiljohn-gh neiljohn-gh commented Jun 17, 2025

Resolves #389

Had to change nonMdsModel to Model and when switching roles, now we use serial number instead of switchDbID.

Old endpoints

GET /appcenter/cisco/ndfc/api/about/version
GET /appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/fabrics/{fabricName}/inventory
GET /appcenter/cisco/ndfc/api/v1/lan-fabric/rest/lanConfig/getLanSwitchCredentials
PUT /fm/fmrest/topology/role/{switchDbId}?newRole=leaf

New endpoints

GET /appcenter/cisco/ndfc/api/v1/fm/about/version
GET /appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/fabrics/{{fabricName}}/inventory/switchesByFabric
GET /appcenter/cisco/ndfc/api/v1/lan-fabric/rest/lanConfig/getLanSwitchCredentialsWithType
POST /appcenter/cisco/ndfc/api/v1/lan-fabric/rest/control/switches/roles

@neiljohn-gh neiljohn-gh requested a review from allenrobel June 17, 2025 07:20
Copy link
Collaborator

@allenrobel allenrobel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. A few minor comments.

@neiljohn-gh neiljohn-gh added the ready for review PR is ready to be reviewed label Jul 22, 2025
@mikewiebe mikewiebe merged commit e8a931a into CiscoDevNet:develop Aug 4, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dcnm_inventory: Use of unpublished NDFC endpoints
3 participants