Skip to content

Replaced changed flag #424 #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

neiljohn-gh
Copy link
Collaborator

Fix for issue #424 (replaced state not showing correct changed flag when attachments are deleted)

Changelog:

  • removed networks from diff_deploy if network deploy attribute is set to false in get_diff_replace
  • added function to detach attachments and deploy the network before a delete to handle case when network is pending
  • added retry count to wait_for_del_ready to prevent potential infinite loop (timeout is after 100 seconds)
  • changed checking for del_ready from get network attachment to get network status
  • fixed integration test templates to set deploy flag properly
  • removed obsolete test case
  • modified unit tests to match new endpoint

@neiljohn-gh neiljohn-gh requested a review from mikewiebe June 30, 2025 10:26
@neiljohn-gh neiljohn-gh self-assigned this Jun 30, 2025
@neiljohn-gh neiljohn-gh added the bug Something isn't working label Jun 30, 2025
@mikewiebe
Copy link
Collaborator

@neiljohn-gh Looks like there are conflicts that need to be resolved. I will review once you address those. Thanks!

@neiljohn-gh neiljohn-gh added the ready for review PR is ready to be reviewed label Jul 22, 2025
Copy link
Collaborator

@mikewiebe mikewiebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neiljohn-gh Nice job on this! This fixed a very critical issue that could be encountered in our solution collection. Tested many different scenarios and it worked very well!

@mikewiebe mikewiebe merged commit cfbb0d8 into CiscoDevNet:develop Aug 8, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ready for review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants