-
Notifications
You must be signed in to change notification settings - Fork 46
Release 3.8.1 #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Release 3.8.1 #458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… constraint and add default value (#427)
* Refactored SANITY test cases, top level playbook and added pydantic schema and helper functions to compare actual and expected data * Refactored DELETED tests, added extension to handle deleted network checks in action plug in, updated schema, updated tags * fixed sanity CI checks * Fixes sanity CI checks * fixed ignores error, added pydantic and deepdiff in the github actions workflow * refactored tests so that variables are defined only once, restructured action plugins to make it more readable, finished query and overridden * fixed ignores error * rearranged argument assignment and checking in action plugin * refactored merged and replaced. Added ignore_fields to process_deepdiff. moved templates into separate folders * fixed issue with check_deleted when config_path is empty * only check changed attribute for idempotency as response may not be of 0 length * improved pydantic parser * refactored self contained tests for DCNM network * fixed minor issues and merged invalid parameters * changed parse_obj to model_validate for pydantic
* "Workflow Sanity - Ignore Files Sorting" * Remove comments --------- Co-authored-by: = <=>
* Update dcnm_network.py add condition if fabric is Multisite, remove mcastGroup key * Update dcnm_network.py fix pylint issue * Fix unit tests --------- Co-authored-by: mwiebe <mwiebe@cisco.com>
* Fix device not reachable scenarios * Fix comments * Handle remove case * Fix github actions issue * Add clarifying comments * Add clarifying comments
* Update dcnm_interface.py refactor breakout * fix trainling whitespace * fix pep8 issue * Update dcnm_interface.py * Update dcnm_interface.py * Fix unit tests * Update integtation tests * Add ansible.cfg file * Fix orphan port bug * Add missing docs --------- Co-authored-by: mwiebe <mwiebe@cisco.com>
* Update galaxy.yml * Update CHANGELOG.rst * Update README.md
AKDRG
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.