Resolving dcnm vpc pair keyError with ipAddress

[sivakasi-cisco]

Problem statement:
KeyError with IpAddress in vpc pair module
"/tmp/ansible_cisco.dcnm.dcnm_vpc_pair_payload_7o9s47zc/ansible_cisco.dcnm.dcnm_vpc_pair_payload.zip/ansible_collections/cisco/dcnm/plugins/module_utils/network/dcnm/dcnm.py", line 757, in dcnm_get_template_specs\nKeyError: 'ipAddress'\n",
"module_stdout": "",
"msg": "MODULE FAILURE\nSee stdout/stderr for the exact error",
"rc": 1
}

Root cause:
The ipAddress field is missing with dcnm template xlation

Fix
Changes to add ipAddress field along with IT test for dcnm vpc pair

[sivakasi-cisco]

#422

[sivakasi-cisco]

Overall in the second changeset, I had removed all the changes made in the integration test yaml files. This is because, the actual problem lied with useVirtualPeerLink variable, as being set as null (or) None (or) False in different files. Hence, the variable set and the response obtained from NDFC are different, which shows a difference in comparison, leading to generating a diff in idemopotent tests.

Now, in the fix, the changes are made so that, the variable "useVirtualPeerLink" is set to false uniformly(being a boolean variable). Also the want and have comparison checks are updated.

[sivakasi-cisco]

Hi Peter @peter8498, Can you please test the diffs and help us to confirm if these changes solve the issue reported in #422

[peter8498]

Hi Peter @peter8498, Can you please test the diffs and help us to confirm if these changes solve the issue reported in #422

I have taken the change and deployed on my environment and can confirm this resolves the orginal issue we were seeing. So happy for this to be merged

[peter8498]

Hi Peter @peter8498, Can you please test the diffs and help us to confirm if these changes solve the issue reported in #422

I have taken the change and deployed on my environment and can confirm this resolves the orginal issue we were seeing. So happy for this to be merged

Update: I noticed there was a small change in the PR since the last time i tested. Re-ran the test i have to create the VPC pair with the updated collection code and it is all good and creates all the desired attributes correctly and we no longer see the original issue