fix for #417 (dcnm_network.py - networkName missing in networkTemplateConfig) #485
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @dalamanster for the contribution. @mikewiebe we do need to double check as I think there's a subtle delta here for MSD fabrics. |
|
@dalamanster Thanks for opening the PR to fix. I noticed you are using |
|
@mikewiebe Yes, we are using just this template for now . I am not able to try this PR on MSD / VXLAN fabrics now. Thanks for double check. Template: Network_Classic Fabric Technology: Classic LAN |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is proposed fix for #417 .
Please somebody check it before merge. This is my first PR for this project. I put "netName" and "networkName" variables on all places where also other network parameters were defined/altered.
This helped me to fix the #417 and I am not getting 500 error anymore.