[WIP] VRFs should never deploy when deploy flag is False

[mikewiebe]

Initial Playbook

    - name: Configure VRFs
      cisco.dcnm.dcnm_vrf:
        fabric: nac-msd-fabric1
        state: deleted
        config:
        - vrf_name: NetAsCodeVrf1
          vrf_id: 150001
          vlan_id: 2001
          vrf_intf_desc: Configured by Ansible NetAsCode
          vrf_description: Configured by Ansible NetAsCode
          vrf_int_mtu: 9216
          loopback_route_tag: 12345
          max_bgp_paths: 1
          max_ibgp_paths: 2
          ipv6_linklocal_enable: True
          adv_host_routes: False
          adv_default_routes: True
          static_default_route: True
          disable_rt_auto: False
          netflow_enable: False
          no_rp: False
          trm_enable: False
          redist_direct_rmap: FABRIC-RMAP-REDIST-SUBNET
          attach:
            - ip_address: 10.15.34.13  ## Leaf1
            - ip_address: 10.15.34.14  ## Leaf2
            - ip_address: 10.15.34.15  ## Leaf3
            - ip_address: 10.15.34.16  ## Leaf4
          deploy: false

• Run the playbook above

  • Initially the VRF will be created and attached to each leaf device but NOT deployed as expected

• If the attach list is modified to remove or add attach devices there are cases where the VRF will be deployed even though the deploy flag is false which is not correct.

Fix for this issue should ensure the following

• deploy flag is always honored
• ensure all states will work (merged,replaced,overridden,deleted)
• we should be able to attach and detach any devices in the list when deploy is false

[neiljohn-gh]

added check to ensure payload {"vrfNames": ""} is not added to diff_deploy, as this would trigger deploy call in push_to_remote