Skip to content

Add support for IPv6 redistribute route-map when creating a vrf #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

mkilar123
Copy link
Contributor

Currently the dcnm_vrf module doesn't support the non-default Route Map to be specified for IPv6 redistribution.
The module uses the same API endpoint as the GUI so it seems that the support can quite easily be introduced.

I introduced a new parameter and named it v6_redist_direct_rmap to control the name of IPv6 route map used for redistribution.
In case the name is not specified, a default value would still be used.
The requirement to support v6 route-map in vxlan-as-code came from one of the Customers under:
netascode/ansible-dc-vxlan#540
Yet in order to introduce the functionality, the dcnm_vrf module should be extended first.

  • I built the PR using the latest develop branch,
  • Documentation is also updated,

If required, please let me know and I'll update the name used for the parameter

I used the following task to test the creation (state: merged) and removal (state: deleted) of the vrf.
Tried with both non-default RM name, as well as without specifying the name - to confirm that the default works ok:


  • hosts: MSD_CALO
    any_errors_fatal: true
    gather_facts: no
    collections:

    • cisco.dcnm

    tasks:

    • name: Create vrf
      cisco.dcnm.dcnm_vrf:
      fabric: "MSD_CALO"
      state: merged
      config:
      • vrf_name: ansible-vrf-r1
        vrf_id: 9008011
        vrf_template: Default_VRF_Universal
        vrf_extension_template: Default_VRF_Extension_Universal
        vlan_id: 2001
        redist_direct_rmap: MKILAR_V4_MAP
        v6_redist_direct_rmap: MKILAR_V6_MAP
      • vrf_name: ansible-vrf-r2
        vrf_id: 9008012
        vrf_template: Default_VRF_Universal
        vrf_extension_template: Default_VRF_Extension_Universal
        vlan_id: 2002

Copy link
Collaborator

@mtarking mtarking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants