Remove default value of failure mode attribute of security policy resource

Author: danischm

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 0.3.13 (unreleased)
 
 - Add workaround for issue when concurrently deleting security policy objects where the reference count is not updated
+- BREAKING CHANGE: Remove default value of `failure_mode` attribute of `sdwan_security_policy` resource
 
 ## 0.3.12
 

docs/guides/changelog.md

@@ -10,6 +10,7 @@ description: |-
 ## 0.3.13 (unreleased)
 
 - Add workaround for issue when concurrently deleting security policy objects where the reference count is not updated
+- BREAKING CHANGE: Remove default value of `failure_mode` attribute of `sdwan_security_policy` resource
 
 ## 0.3.12
 

docs/resources/security_policy.md

@@ -51,7 +51,6 @@ resource "sdwan_security_policy" "example" {
   - Choices: `allow`, `deny`
 - `failure_mode` (String) Failure mode
   - Choices: `open`, `close`
-  - Default value: `open`
 - `high_speed_logging_server_ip` (String) High Speed Logging Server IP
 - `high_speed_logging_server_port` (String) High Speed Logging Port
 - `high_speed_logging_vpn` (String) High Speed Logging VPN

gen/definitions/generic/security_policy.yaml

@@ -96,7 +96,6 @@ attributes:
     data_path: [policyDefinition, settings]
     tf_name: failure_mode
     type: String
-    default_value: open
     enum_values: [open, close]
     description: Failure mode
     example: close

internal/provider/resource_sdwan_security_policy.go

@@ -152,13 +152,11 @@ func (r *SecurityPolicyResource) Schema(ctx context.Context, req resource.Schema
 				},
 			},
 			"failure_mode": schema.StringAttribute{
-				MarkdownDescription: helpers.NewAttributeDescription("Failure mode").AddStringEnumDescription("open", "close").AddDefaultValueDescription("open").String,
+				MarkdownDescription: helpers.NewAttributeDescription("Failure mode").AddStringEnumDescription("open", "close").String,
 				Optional:            true,
-				Computed:            true,
 				Validators: []validator.String{
 					stringvalidator.OneOf("open", "close"),
 				},
-				Default: stringdefault.StaticString("open"),
 			},
 			"high_speed_logging_server_ip": schema.StringAttribute{
 				MarkdownDescription: helpers.NewAttributeDescription("High Speed Logging Server IP").String,

templates/guides/changelog.md.tmpl

@@ -10,6 +10,7 @@ description: |-
 ## 0.3.13 (unreleased)
 
 - Add workaround for issue when concurrently deleting security policy objects where the reference count is not updated
+- BREAKING CHANGE: Remove default value of `failure_mode` attribute of `sdwan_security_policy` resource
 
 ## 0.3.12