[UX2.0] Service lan_vpn_feature static route gateway configuration enhancement

[rchrabas]

Description

Add gateway attribute for ipv4_static_routes and ipv6_static_routes in sdwan_service_lan_vpn_feature resource.
Resolving issue #463

Types of Changes

• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Breaking change (fix or feature that would cause existing functionality to change)
• Build/CI change
• Code quality improvement/refactoring/documentation (no functional changes)

Checklist

• My code follows the code style of this project
• I have added tests to cover my changes
• All new and existing tests pass locally

[koval4ukav]

Tested and working as expected.
I think it makes sense to update the name of boolean attribute gateway_dhcp just todhcp, as now we have gateway condition attribute added.

[rchrabas]

Do we even need gateway_dhcp attribute? Won't gateway = dhcp imply gateway_dhcp = true?

[koval4ukav]

Good point, agree, same will apply then for vpn and null0 boolean attributes. Gateway choice will assign true value for corresponding parameter.

[seconroy]

I agree with changing gateway_dhcp to dhcp but I'm not so sure about gateway = dhcp. Generally in the provider we try to align to the schema. gateway does not exist in the schema but was implemented in transport_wan_vpn for a reason which was to support default values and we are updating here to match that even though there is no functional requirements or default values in service_lan_vpn.

While I do agree it is cleaner, I'm just not sure about adding even more logic to parameters that are not present in the schema. Additionally, we would then need to update transport_wan_vpn which would require changes to modules. I'm happy to discuss in standup but could we add to it to the backup until we have fixed the current set of import issues as this would complicate the import further...

[rchrabas]

Renamed attribute gateway_dhcp to dhcp.