Skip to content

Resolve Issue #477 #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 7, 2025
Merged

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Jul 23, 2025

Description

Resolves issue #477

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy changed the title Resolve Issue #447 Resolve Issue #477 Jul 23, 2025
@seconroy seconroy marked this pull request as ready for review August 4, 2025 11:58
@rrahimm
Copy link

rrahimm commented Aug 4, 2025

Testing

Without Fix

 # module.sdwan.sdwan_localized_policy.localized_policy["TEST"] will be created
  + resource "sdwan_localized_policy" "localized_policy" {
      + application_visibility_ipv4 = true
      + application_visibility_ipv6 = true
      + cloud_qos                   = true
      + cloud_qos_service_side      = true
      + definitions                 = [
          + {
              + id      = (known after apply)
              + type    = "acl"
              + version = (known after apply)
            },
        ]
      + description                 = "TEST"
      + flow_visibility_ipv4        = true
      + flow_visibility_ipv6        = true
      + id                          = (known after apply)
      + implicit_acl_logging        = true
      + name                        = "TEST"
      + version                     = (known after apply)
    }
image

With Fix

# module.sdwan.sdwan_localized_policy.localized_policy["TEST"] will be created
  + resource "sdwan_localized_policy" "localized_policy" {
      + definitions = [
          + {
              + id      = (known after apply)
              + type    = "acl"
              + version = (known after apply)
            },
        ]
      + description = "TEST"
      + id          = (known after apply)
      + name        = "TEST"
      + version     = (known after apply)
    }
image

@danischm danischm merged commit 72d5353 into CiscoDevNet:main Aug 7, 2025
3 checks passed
@danischm danischm deleted the resolve-issue-477 branch August 7, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants