Skip to content

Resolve Issue #433 #484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

Resolve Issue #433 #484

merged 1 commit into from
Aug 7, 2025

Conversation

seconroy
Copy link
Collaborator

@seconroy seconroy commented Jul 23, 2025 •
edited
Loading

Description

Resolves issue #433, Adds conditional attribute to all tunnel attributes so they are only included when tunnel_interface is true

Types of Changes

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Build/CI change
  • Code quality improvement/refactoring/documentation (no functional changes)

Checklist

  • My code follows the code style of this project
  • I have added tests to cover my changes
  • All new and existing tests pass locally

@seconroy seconroy marked this pull request as ready for review July 23, 2025 15:23
@seconroy seconroy requested a review from tzarski0 July 23, 2025 15:23
@danischm danischm merged commit 6abb0fb into CiscoDevNet:main Aug 7, 2025
3 checks passed
@danischm danischm deleted the resolve-issue-433 branch August 7, 2025 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danischm danischm danischm approved these changes

@tzarski0 tzarski0 tzarski0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seconroy @danischm @tzarski0