Skip to content

Add a performance benchmark pipeline #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Apr 23, 2025

Conversation

simone-silvestri
Copy link
Collaborator

@simone-silvestri simone-silvestri commented Apr 9, 2025

Which can be triggered on PRs by adding the benchmark performance label.
These tests at the moment run on Tartarus GPU number 1. We probably need a better GPU / a GPU we know is free to perform these tests.

@simone-silvestri
Copy link
Collaborator Author

I convert this PR to ready to review just to see if GHA starts, however, it is not really ready to review

@simone-silvestri simone-silvestri marked this pull request as ready for review April 9, 2025 18:05
@navidcy navidcy added performance 🏍️ So we can get the wrong answer even faster testing 🧪 Tests get priority in case of emergency evacuation labels Apr 9, 2025
with:
version: ${{ matrix.version }}
arch: ${{ matrix.arch }}
- uses: actions/cache@v4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to use the cache-julia step.

@simone-silvestri simone-silvestri added the benchmark performance runs preconfigured benchamarks and spits out timing label Apr 23, 2025
@simone-silvestri
Copy link
Collaborator Author

Just as a test, I have added here a pipeline-benchmarks.yml that runs on Tartarus (GPU 0) only if adding the benchmark performance label to the PR.
The pipeline uses nsys to benchmark a representative script and spits out statistics with nsys stats.
I am not sure if this is the correct approach. Is there a way to call the pipeline through a comment in the PR and have it spit out the results in a comment?
@vchuravy

@simone-silvestri simone-silvestri changed the title Add a performance benchmark GHA Add a performance benchmark pipeline Apr 23, 2025
@simone-silvestri simone-silvestri merged commit fa62396 into main Apr 23, 2025
59 checks passed
@simone-silvestri simone-silvestri deleted the ss/performance-github-action branch April 23, 2025 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark performance runs preconfigured benchamarks and spits out timing performance 🏍️ So we can get the wrong answer even faster testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants