Add grid reconstruction utilities to reconstruct Grids from NetCDF outputs #4660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
navidcy
reviewed
Jul 22, 2025
navidcy
reviewed
Jul 22, 2025
navidcy
reviewed
Jul 22, 2025
navidcy
reviewed
Jul 22, 2025
navidcy
reviewed
Jul 22, 2025
|
Oh sorry, I only noticed it was a draft after I made the suggestions! :( |
Co-authored-by: Navid C. Constantinou <navidcy@users.noreply.github.com>
No worries at all! Comments are always appreciated :) I'll address them soon. |
navidcy
added
question 💭
…jl into tc/reconstruct-grids
|
I realized that grid, currently, equality only works properly for non-immersed grids, as it doesn't compare anything related to immersed boundaries. I want this feature to be available for immersed grids as well, as the tests would be much simpler with proper equality testing for immersed grids, so I'm going to open that PR first before testing immersed grids here. Otherwise this PR is more or less ready. |
glwagner
reviewed
Aug 6, 2025
glwagner
reviewed
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed to complete #3935