Skip to content

Use CG as fallback solver for all cases #4720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −8
Open

Use CG as fallback solver for all cases #4720

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/Models/NonhydrostaticModels/NonhydrostaticModels.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ nonhydrostatic_pressure_solver(arch, grid::XYZRegularRG) = FFTBasedPoissonSolver
nonhydrostatic_pressure_solver(arch, grid::GridWithFourierTridiagonalSolver) =
FourierTridiagonalPoissonSolver(grid)

# A LatitudeLongitudeGrid cannot use an FFT-based solver, we use a conjugate gradient solver instead.
nonhydrostatic_pressure_solver(arch, grid::LatitudeLongitudeGrid) =
ConjugateGradientPoissonSolver(grid)
# fallback
nonhydrostatic_pressure_solver(arch, grid) = ConjugateGradientPoissonSolver(grid)

const IBGWithFFTSolver = ImmersedBoundaryGrid{<:Any, <:Any, <:Any, <:Any, <:GridWithFFTSolver}

Expand All @@ -58,11 +57,6 @@ function nonhydrostatic_pressure_solver(arch, ibg::IBGWithFFTSolver)
return nonhydrostatic_pressure_solver(arch, ibg.underlying_grid)
end

# fallback
nonhydrostatic_pressure_solver(arch, grid) =
error("None of the implemented pressure solvers for NonhydrostaticModel \
are supported on $(summary(grid)).")

nonhydrostatic_pressure_solver(grid) = nonhydrostatic_pressure_solver(architecture(grid), grid)

#####
Expand Down
Loading