Skip to content

add arm windows npipe file #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: v2
Choose a base branch
from
Open

Conversation

ph4r05
Copy link

@ph4r05 ph4r05 commented May 27, 2024

I tried copying znpipe_windows_amd64.go to znpipe_windows_arm64.go and it worked.

go install golang.org/x/sys/windows/mkwinsyscall@latest
GOOS=windows GOARCH=arm64 ~/go/bin/mkwinsyscall.exe npipe_windows.go > znpipe_windows_arm64.go

Turns out, znpipe_windows_arm64.go is the same as znpipe_windows_amd64.go

@rgooch rgooch requested a review from cviecco June 9, 2024 17:04
@cviecco
Copy link

cviecco commented Jun 11, 2024

  1. Why has this not landed upstream?
  2. This file seems identical to the amd64 file... why not just update the build directives in the other file? (and rename it to reflect is for windows?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants