Skip to content

feat: updated eslint, dependency upgrades #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025
Merged

Conversation

CodeDead
Copy link
Owner

No description provided.

@CodeDead CodeDead added enhancement New feature or improvement dependencies Pull requests that update a dependency file labels Apr 18, 2025
@CodeDead CodeDead self-assigned this Apr 18, 2025
@CodeDead CodeDead requested a review from Copilot April 18, 2025 14:46
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ESLint configuration and upgrades various dependencies while cleaning up code formatting across multiple components. Key changes include:

  • Refactored component imports and JSX formatting for consistency.
  • Upgraded dependency versions (tauri, rand, etc.) and updated workflow configurations.
  • Introduced a new ESLint configuration with updated linting rules.

Reviewed Changes

Copilot reviewed 44 out of 49 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/components/PasswordTips/index.jsx Reformatted code and updated tip generation logic
src/components/LoadingBar/index.jsx Minor JSX formatting adjustments
src/components/LinearProgressWithLabel/index.jsx Updated import order to align with best practices
src/components/GridList/index.jsx Consolidated props into a single destructuring pattern
src/components/EncryptionKeyDialog/index.jsx Removed duplicate imports and cleaned up JSX
src/components/EditPasswordDialog/index.jsx Reformatted state initialization and code style
src/components/CreatePasswordDialog/index.jsx Cleaned up JSX and improved dependency imports
src/components/ClippedDrawer/index.jsx Changed import order and revised drawer structure
src/components/App/index.jsx Adjusted import ordering and JSX structure
src/components/AlertDialog/index.jsx Simplified JSX formatting in dialog component
src-tauri/Cargo.toml Upgraded tauri and rand dependencies
index.html Changed DOCTYPE for consistency
eslint.config.js Added a comprehensive ESLint configuration
.github/workflows/test.yml Updated workflow configuration and dependency installs
.github/workflows/release.yml Revised release workflow steps and build configurations
Files not reviewed (5)
  • .eslintignore: Language not supported
  • .eslintrc.json: Language not supported
  • .prettierignore: Language not supported
  • .prettierrc: Language not supported
  • package.json: Language not supported
Comments suppressed due to low confidence (2)

src/components/PasswordTips/index.jsx:45

  • The condition is checking the ref object (intervalId) rather than its current property. Consider using 'intervalId.current !== null' to correctly determine if the interval is set.
return () => intervalId !== null ? clearInterval(intervalId.current) : null;

src/components/GridList/index.jsx:7

  • The 'size' prop is not a standard prop for MUI's Grid component. Replace it by using the 'item' prop and passing breakpoint props (e.g., xs, md, lg) directly to ensure proper layout behavior.
<Grid key={i} size={{ xs, md, lg }}>

@CodeDead CodeDead merged commit 4eebb43 into development Apr 18, 2025
7 checks passed
@CodeDead CodeDead deleted the feature/upgrades branch April 18, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant