Feat: add recent activity as ML feature #1173
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or all properties for ML feature engineering
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
adamzev
reviewed
May 10, 2025
|
|
||
|
|
||
| def fetch_recent_activity(query: str) -> pd.DataFrame: | ||
| response = requests.get("https://phl.carto.com/api/v2/sql", params={"q": query}) |
There was a problem hiding this comment.
We already should have a class that is capable of grabbing a carto query and converting the results to a df. Is there are reason it didn't work for this case?
I'd like to keep with using that class rather than duplicating the functionality.
|
Generally, this looks ready to go. I just had one thing I think we should change regarding the carto API call. |
|
This PR has been marked as stale because it has been open for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add recent activity for ML features
Description
This PR adds permits, business licenses, and appeals data for each property in the dataset, tracking whether there has ever been such a record associated with a given
opa_id, as well as the date of the most recent record and the days since that date (to the date of the pipeline run). My hunch is that some combination of these features will significantly improve our ability to identify vacant properties with ML.