-
Notifications
You must be signed in to change notification settings - Fork 0
Synchronization code and notifications #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…aak' into feature/GW-1736/test-with-mapping
warning: this will cause infinite loops. Working on that
…aak' into feature/GW-1736/test-with-mapping
…g' into feature/GW-1736/test-with-mapping
👋 @rjzondervan
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -0,0 +1,34 @@ | |||
{ | |||
"title": "Sync Cases from VrijBRP", | |||
"$id": "https://commongateway.nl/action/vrijbrp.synczaken.action.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use vrijbrp.nl here instead
different domain than mappings from https://github.com/CommonGateway/VrijBRPToZGWBundle/pull/1/files
might be better to be consistent with these references
https://github.com/CommonGateway/VrijBRPToZGWBundle/pull/2/files#r1787422666
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the domain from https://github.com/CommonGateway/VrijBRPToZGWBundle/pull/1/files, that's exactly why I changed the domains to commongateway.nl
@@ -0,0 +1,21 @@ | |||
{ | |||
"title": "CreateCaseNotification", | |||
"$id": "https://commongateway.nl/action/vrijbrp.createCaseNotification.action.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use vrijbrp.nl here instead
@@ -0,0 +1,21 @@ | |||
{ | |||
"title": "CreateStatusNotification", | |||
"$id": "https://commongateway.nl/action/vrijbrp.createStatusNotification.action.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe use vrijbrp.nl here instead
Installation/Action/vrijbrp.createStatusNotification.action.json
Outdated
Show resolved
Hide resolved
* | ||
* @return Synchronization The updated synchronization | ||
*/ | ||
public function synchronizeFromSource(Synchronization $synchronization, array $sourceObject=[], bool $unsafe=false): Synchronization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan naar deze functie gekeken worden? Aardig wat warnings erop? Complexiteit etc
$this->synchronizationLogger->info("handleSync for Synchronization with id = {$synchronization->getId()->toString()}"); | ||
|
||
// create new object if no object exists | ||
if (!$synchronization->getObject()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan !== null
|
||
if ($resultDot->has(keys: $configuration['resultsPath']) === true) { | ||
$return = $resultDot->get(key: $configuration['resultsPath']); | ||
if ($return instanceof Dot) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan === true
$return = $resultDot->get(key: $configuration['resultsPath']); | ||
if ($return instanceof Dot) { | ||
return $return->jsonSerialize(); | ||
} else if (is_array($return)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan === true
src/Service/VrijBrpService.php
Outdated
{ | ||
$object = $data['object']; | ||
|
||
if ($object instanceof ObjectEntity) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kan === true
No description provided.