Versioning-and-release #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinyoo
reviewed
Sep 10, 2024
| <PackageReference Include="Aspire.Hosting" /> | ||
| </ItemGroup> | ||
| <PropertyGroup> | ||
| <PackageReadmeFile>hosting-azure-static-web-apps.md</PackageReadmeFile> |
There was a problem hiding this comment.
When I look at the package, it shows the repository's README, instead of this file.
Is that supposed to be?
There was a problem hiding this comment.
I think this might be how GitHub Packages works, until we get it published to nuget.org I'm not sure if we can be sure this isn't working.
|
I have to look into why it's doing that and not respecting the value set. It should use the docs page for the package
Get Outlook for Android<https://aka.ms/AAb9ysg>
________________________________
From: Justin Yoo ***@***.***>
Sent: Tuesday, September 10, 2024 6:26:11 PM
To: CommunityToolkit/Aspire ***@***.***>
Cc: Aaron Powell ***@***.***>; Author ***@***.***>
Subject: Re: [CommunityToolkit/Aspire] Versioning-and-release (PR #14)
@justinyoo commented on this pull request.
It would be great if the package displays its package readme, instead of the repository's readme
________________________________
In src/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps.csproj<#14 (comment)>:
@@ -1,5 +1,5 @@
<Project Sdk="Microsoft.NET.Sdk">
- <ItemGroup>
- <PackageReference Include="Aspire.Hosting" />
- </ItemGroup>
+ <PropertyGroup>
+ <PackageReadmeFile>hosting-azure-static-web-apps.md</PackageReadmeFile>
When I look at the package, it shows the repository's README, instead of this file.
https://github.com/CommunityToolkit/Aspire/pkgs/nuget/CommunityToolkit.Aspire.Hosting.Azure.StaticWebApps
Is that supposed to be?
—
Reply to this email directly, view it on GitHub<#14 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AADJ7XGKEVQZMDSD3RBHBHLZV2UKHAVCNFSM6AAAAABN6A2Y76VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDEOJRG4ZTANRRGU>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
aaronpowell
had a problem deploying
to
github-packages
GitHub Actions
Failure
aaronpowell
temporarily deployed
to
github-packages
GitHub Actions
Inactive
aaronpowell
temporarily deployed
to
github-packages
GitHub Actions
Inactive
aaronpowell
temporarily deployed
to
github-packages
GitHub Actions
Inactive
justinyoo
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.