-
Notifications
You must be signed in to change notification settings - Fork 110
Ollama #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Ollama #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial development
Making the `ModelName` property public for read-only access.
davidfowl
reviewed
Sep 18, 2024
src/CommunityToolkit.Aspire.Hosting.Ollama/OllamaResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 18, 2024
src/CommunityToolkit.Aspire.Hosting.Ollama/OllamaResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 18, 2024
src/CommunityToolkit.Aspire.Hosting.Ollama/OllamaResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Sep 18, 2024
src/CommunityToolkit.Aspire.Hosting.Ollama/OllamaResourceBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
The hook is run before the container image is downloaded (and ollama started) when you run from a completely clean session (like GitHub Actions), and this poses a problem because it would timeout trying to check if the model exists. Added a really simple bit of retry logic in to counter that
…hich isn't the name and thus returns null and fails
aaronpowell
commented
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
The folks from Raygun have donated their Ollama package, which has served as the starting point for what is in this PR.
PR Checklist
Other information
Thanks to @QuantumNightmare for the initial work!