Skip to content

Ollama #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Sep 24, 2024
Merged

Ollama #26

merged 33 commits into from
Sep 24, 2024

Conversation

aaronpowell
Copy link
Member

@aaronpowell aaronpowell commented Sep 18, 2024

Closes #23

The folks from Raygun have donated their Ollama package, which has served as the starting point for what is in this PR.

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Thanks to @QuantumNightmare for the initial work!

@aaronpowell aaronpowell self-assigned this Sep 18, 2024
@aaronpowell aaronpowell added the integration A new .NET Aspire integration label Sep 18, 2024
The hook is run before the container image is downloaded (and ollama started) when you run from a completely clean session (like GitHub Actions), and this poses a problem because it would timeout trying to check if the model exists. Added a really simple bit of retry logic in to counter that
…hich isn't the name and thus returns null and fails
@aaronpowell aaronpowell marked this pull request as ready for review September 19, 2024 06:43
@aaronpowell aaronpowell merged commit 91da0ec into main Sep 24, 2024
4 checks passed
@aaronpowell aaronpowell deleted the ollama branch September 24, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration A new .NET Aspire integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ollama
3 participants