-
Notifications
You must be signed in to change notification settings - Fork 110
Add Adminer support for MySql #686
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces MySQL hosting integration with Adminer support for the Aspire project. It adds new MySQL extensions, updates tests and examples to verify the Adminer functionality, revises project and solution files, and adjusts the CI workflow to include MySQL tests.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/CommunityToolkit.Aspire.Hosting.MySql.Extensions.Tests/ResourceCreationTests.cs | Adds tests for verifying environment annotations and Adminer configuration for MySQL resources. |
tests/CommunityToolkit.Aspire.Hosting.Adminer.Tests/AddAdminerTests.cs | Updates tests to include MySQL resource scenarios within multi-database Adminer configurations. |
src/CommunityToolkit.Aspire.Hosting.MySql.Extensions/MySqlBuilderExtensions.cs | Implements the Adminer integration extension method and environment configuration logic for MySQL hosting. |
README.md, .csproj, examples/, Directory.Packages.props, CommunityToolkit.Aspire.sln | Add project references, documentation, and configuration updates to support the new MySQL integration. |
.github/workflows/tests.yaml | Updates test workflows to include MySQL integration tests. |
Comments suppressed due to low confidence (1)
src/CommunityToolkit.Aspire.Hosting.MySql.Extensions/MySqlBuilderExtensions.cs:59
- [nitpick] Consider renaming 'new_servers' to 'newServers' to follow C# naming conventions for local variables.
var new_servers = mysqlInstances.ToDictionary(
tests/CommunityToolkit.Aspire.Hosting.MySql.Extensions.Tests/ResourceCreationTests.cs
Show resolved
Hide resolved
Minimum allowed line rate is |
Contributes to #643
This pull request introduces a new integration for MySQL hosting with Adminer support in the
CommunityToolkit.Aspire
project. It includes updates to workflows, solution files, examples, and tests to support the new functionality. The most important changes are grouped below by theme.Workflow and Solution Updates:
.github/workflows/tests.yaml
to include new MySQL-related tests (Hosting.MySql.Extensions.Tests
) and reorganized test entries for consistency. [1] [2]CommunityToolkit.Aspire.sln
solution file, includingCommunityToolkit.Aspire.Hosting.MySql.Extensions
and related test and example projects. [1] [2] [3]MySQL Integration:
CommunityToolkit.Aspire.Hosting.MySql.Extensions
with aWithAdminer
extension method to integrate Adminer for MySQL hosting. This includes support for configuring Adminer containers and managing MySQL server resources. [1] [2]README.md
file for the MySQL extensions project, providing documentation and usage examples.Examples:
examples/mysql-ext
) demonstrating the MySQL integration with Adminer, including configuration files likeProgram.cs
,appsettings.json
, andlaunchSettings.json
. [1] [2] [3] [4]Tests:
CommunityToolkit.Aspire.Hosting.MySql.Extensions.Tests
to verify the functionality of the MySQL integration, including a test to ensure the Adminer resource starts and responds correctly. [1] [2]Dependency Updates:
Directory.Packages.props
to include the newAspire.Hosting.MySql
package version.PR Checklist
Other information