-
Notifications
You must be signed in to change notification settings - Fork 110
SWA test stability #697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
aaronpowell
merged 7 commits into
main
from
677-swa-functional-tests-failed-repeatedly-in-linux-and-windows-1
May 24, 2025
Merged
SWA test stability #697
aaronpowell
merged 7 commits into
main
from
677-swa-functional-tests-failed-repeatedly-in-linux-and-windows-1
May 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update project references and improve app setup - Added project reference for `CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj` in `CommunityToolkit.Aspire.StaticWebApps.AppHost.csproj`. - Changed web app setup in `Program.cs` from `.AddNpmApp` to `.AddViteApp` with `.WithNpmPackageInstallation()`. - Modified `Port` property in `SwaResourceOptions.cs` to use a random port between 4280 and 5280. - Updated tests in `SwaHostingComponentTests.cs` to utilize `CancellationToken` for better control over async operations. Related Work Items: #6, #677
Minimum allowed line rate is |
10 tasks
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update project references and improve app setup
CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj
inCommunityToolkit.Aspire.StaticWebApps.AppHost.csproj
.Program.cs
from.AddNpmApp
to.AddViteApp
with.WithNpmPackageInstallation()
.Port
property inSwaResourceOptions.cs
to use a random port between 4280 and 5280.SwaHostingComponentTests.cs
to utilizeCancellationToken
for better control over async operations.Related Work Items: #698, #677
Closes #<ISSUE_NUMBER>
PR Checklist
Other information