Skip to content

Golang Integration #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 24 commits into from
Oct 8, 2024
Merged

Golang Integration #71

merged 24 commits into from
Oct 8, 2024

Conversation

tommasodotNET
Copy link
Contributor

Closes #43

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • New integration
    • Docs are written
    • Added description of major feature to project description for NuGet package (4000 total character limit, so don't push entire description over that)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure all workflows are updated then it's probably good to go.

@aaronpowell aaronpowell added the integration A new .NET Aspire integration label Oct 7, 2024
@tommasodotNET
Copy link
Contributor Author

tommasodotNET commented Oct 8, 2024

good to go.

pun intended (focus on the "go")? 😆

@aaronpowell aaronpowell merged commit 5e88805 into main Oct 8, 2024
7 checks passed
@aaronpowell aaronpowell deleted the issue43 branch October 8, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration A new .NET Aspire integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Golang
2 participants