Allow publishing of Ollama and SQLite hosting integrations #710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egrations Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
aaronpowell
June 3, 2025 04:54
aaronpowell
requested changes
Jun 3, 2025
| @@ -51,8 +51,7 @@ public static IResourceBuilder<T> WithOpenWebUI<T>(this IResourceBuilder<T> buil | |||
| .WithHttpEndpoint(targetPort: 8080, name: "http") | |||
| .WithEnvironment(context => ConfigureOpenWebUIContainer(context, openWebUI)) | |||
| .WaitFor(builder) | |||
| .WithHttpHealthCheck("/health") | |||
There was a problem hiding this comment.
Done! I've restored the .ExcludeFromManifest() call for the OpenWebUI resource and updated the corresponding test. The change is in commit f29d95f.
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
aaronpowell
June 3, 2025 05:03
Minimum allowed line rate is |
aaronpowell
approved these changes
Jun 3, 2025
|
@Alirexaa - I've enabled Copilot as a pair programmer (mostly for an experiment). This is the kind of outcome from it. |
This is cool, but I'm unable to assign the issues to Copilot. I have |
|
I'll check permissions, you should be able to as it's org level that I set it up as. |
I thought that because it was at the org level it should still allow you but looks like not (although I'm somewhat confused on how the pricing/licensing works, maybe I should ask copilot...) |
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the automatic
ExcludeFromManifest()calls from the Ollama and SQLite hosting integrations, allowing developers to choose whether to include these resources in their publishing manifest.Problem
Previously, these integrations automatically excluded themselves from the manifest:
While this was done with good intentions (these resources might not be recommended for production deployment), it caused friction by:
Solution
Removed the automatic
.ExcludeFromManifest()calls from all four resources, allowing them to participate in manifest generation by default. Developers who don't want these resources in their manifest can now explicitly call.ExcludeFromManifest()when configuring the resources.Changes Made
Source Code:
.ExcludeFromManifest()fromOllamaResourceBuilderExtensions.cs(Ollama container).ExcludeFromManifest()fromOllamaResourceBuilderExtensions.OpenWebUI.cs(OpenWebUI).ExcludeFromManifest()fromSqliteResourceBuilderExtensions.cs(SQLite and SQLite Web)Tests:
ResourceExcludedFromManifestByDefault→ResourceIncludedInManifestByDefaultBreaking Change
This is a minimal breaking change - resources that were previously excluded from manifests will now be included by default. Developers who relied on the automatic exclusion can restore the previous behavior by explicitly calling
.ExcludeFromManifest():Fixes #709.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.comdotnet build src/CommunityToolkit.Aspire.Hosting.Ollama/CommunityToolkit.Aspire.Hosting.Ollama.csproj(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.