Add support for DacDeployOption from a publish profile #729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikEJ
requested review from
aaronpowell,
jmezach,
Copilot and
Alirexaa
and removed request for
jmezach
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configuring dacpac deployment options from a publish profile by introducing a new WithDacDeployOptions extension method and related annotations.
- Adds a new WithDacDeployOptions method for both SQL projects and packages.
- Introduces corresponding annotations and tests to validate deployment option loading.
- Updates project and example files to include the publish profile.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests/Database.publish.xml | Added a new XML publish profile for testing. |
| tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests.csproj | Updated project file to copy the publish profile to the output directory. |
| tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests/AddSqlProjectTests.cs | Added tests verifying behavior when using a valid and a non-existing publish profile. |
| tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests/AddSqlPackageTests.cs | Added tests for SQL package resources using the new deployment options. |
| src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlProjectResource.cs | Updated SqlProjectResource to load deployment options from the publish profile. |
| src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlProjectBuilderExtensions.cs | Introduced extension methods for WithDacDeployOptions on SQL projects and packages. |
| src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlPackageResource.cs | Updated SqlPackageResource to load deployment options from the publish profile. |
| src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/DacDeployOptionsAnnotation.cs | Added the new annotation type for dacpac deployment options. |
| examples/sql-database-projects/SdkProject/Database.publish.xml | Provided an example publish profile to demonstrate the new functionality. |
src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlProjectResource.cs
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects/SqlPackageResource.cs
Show resolved
Hide resolved
ErikEJ
changed the title
jmezach
reviewed
Jun 16, 2025
tests/CommunityToolkit.Aspire.Hosting.SqlDatabaseProjects.Tests/AddSqlPackageTests.cs
Outdated
Show resolved
Hide resolved
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #694
Closes #694
Adds a ne WithDacDeployOptions method that takes a path to a publish xml profile
PR Checklist