-
Notifications
You must be signed in to change notification settings - Fork 110
Add support for passing additional arguments to package installation methods #739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Co-authored-by: aaronpowell <434140+aaronpowell@users.noreply.github.com>
Copilot finished work on behalf of
aaronpowell
June 23, 2025 01:23
Minimum allowed line rate is |
aaronpowell
approved these changes
Jun 23, 2025
This implementation really should have exposed the npm resource to the caller so they can do WithArgs. It's fine to have shortcuts but there's another cliff here that we should avoid. |
I guess we could expose that in a callback |
This was referenced Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for passing additional flags to npm, yarn, and pnpm package installation commands, addressing the need to use flags like
--legacy-peer-deps
for legacy packages mentioned in AspiriFridays episode 4.Changes Made
API Updates
WithNpmPackageInstallation
: Added optionalstring[]? args
parameter to pass additional flags to npm commandsWithYarnPackageInstallation
: Added optionalstring[]? args
parameter for yarn flagsWithPnpmPackageInstallation
: Added optionalstring[]? args
parameter for pnpm flagsUsage Examples
Key Features
Testing
Added comprehensive tests that verify:
Documentation
This solves the specific use case mentioned in AspiriFridays where users needed to pass
--legacy
flags to npm for legacy package compatibility.Fixes #738.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
dnceng.pkgs.visualstudio.com
dotnet build src/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj
(dns block)dotnet build src/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.csproj -f net8.0
(dns block)dotnet build tests/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.Tests/CommunityToolkit.Aspire.Hosting.NodeJS.Extensions.Tests.csproj
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.