-
Notifications
You must be signed in to change notification settings - Fork 110
Marking SSE transport as deprecated #775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR marks the SSE (Server Sent Events) transport type as deprecated in the MCP (Model Context Protocol) Inspector integration. The change aligns with the MCP specification's deprecation of SSE transport in favor of StreamableHttp.
- Added
[Obsolete]
attribute to theMcpTransportType.Sse
enum value with guidance to use StreamableHttp instead - Added pragma warnings to suppress obsolete warnings in existing code that still references the deprecated SSE transport type
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/CommunityToolkit.Aspire.Hosting.McpInspector/McpTransportType.cs | Added obsolete attribute to SSE enum value with deprecation message |
src/CommunityToolkit.Aspire.Hosting.McpInspector/McpInspectorResourceBuilderExtensions.cs | Added pragma warnings around SSE transport case in switch statement |
tests/CommunityToolkit.Aspire.Hosting.McpInspector.Tests/McpInspectorResourceBuilderExtensionsTests.cs | Added pragma warnings around SSE test case |
Minimum allowed line rate is |
Fixes #759