Skip to content

feat(surrealdb): ensures ns/db are created in strict mode #790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Odonno
Copy link
Contributor

@Odonno Odonno commented Aug 6, 2025

Given that in strict mode, SurrealDB requires everything to be defined before use including Namespace, Database and Table definitions.

  • Follow the new method definition called WithCreationScript
  • Creates namespace and database when strict mode enabled (not required when disabled)

PR Checklist

  • Created a feature/dev branch in your fork (vs. submitting directly from a commit on main)
  • Based off latest main branch of toolkit
  • PR doesn't include merge commits (always rebase on top of our main, if needed)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Contains NO breaking changes
  • Every new API (including internal ones) has full XML docs
  • Code follows all style conventions

Other information

Copy link
Member

@aaronpowell aaronpowell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a test is failing too.

@Odonno Odonno force-pushed the feat/surrealdb-create-ns-db branch from ff37de2 to ce844a4 Compare August 8, 2025 19:05
@aaronpowell aaronpowell merged commit 332bca0 into CommunityToolkit:main Aug 11, 2025
100 checks passed
@Odonno Odonno deleted the feat/surrealdb-create-ns-db branch August 11, 2025 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants