Skip to content

Job reschedule implementation change #6277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: uj/arch-distill
Choose a base branch
from

Conversation

kanwarujjaval
Copy link
Member

enhance updateSchedule to accept optional job data and improve job cancellation logic

@kanwarujjaval kanwarujjaval requested a review from Copilot June 3, 2025 12:41
@kanwarujjaval kanwarujjaval self-assigned this Jun 3, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Enhances the updateSchedule method to accept optional job payloads and refines how existing scheduled tasks are cancelled before rescheduling.

  • Adds an optional data parameter to updateSchedule and includes it in debug logs
  • Switches from removing a single job instance to cancelling all pending future runs
  • Passes the new data payload into both repeating and one-time scheduling calls
Comments suppressed due to low confidence (1)

jobServer/PulseJobRunner.js:297

  • No unit tests were added to verify the new data parameter propagation or the enhanced cancellation logic. Consider adding tests to cover these code paths.
async updateSchedule(jobName, schedule, data = {}) {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant