-
Notifications
You must be signed in to change notification settings - Fork 9
Change usize to u64 for all variables that aren't indices into byte-based structures #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Cydhra
wants to merge
20
commits into
dev_2.0
Choose a base branch
from
dev_2.0_u64
base: dev_2.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…it was used and where not, so it doesnt serve a purpose anyway
…oblems outside wavelet implementation
…confused the loop variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit vectors can hold more bits than
usize::MAX
, and therefore all bit-indexing and length calculation should be performed withu64
instead.This has some unfortunate side effects that need to be addressed
usize::MAX
elements. Code paths where this can be circumvented should be special-cased for <64 bit plattforms, and where it can't there should be documentation about potential panics.take()
andskip()
in iterators takes a usize, which means subtrees in BP that exceed 2^32 bits cannot be handled properly.u64
tousize
for indexing byte-based structures, care must be taken that conversions happen in the correct order