Skip to content

bug fix: journal.lua minor performance lost due to typo "colllapsed" #1469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2025
Merged

bug fix: journal.lua minor performance lost due to typo "colllapsed" #1469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a719636
bug fix: journal.lua minor performance lost due to typo "colllapsed"
LouisGameDev Jun 26, 2025
28cef16
add changelog
ab9rf Jul 2, 2025
a1d4881
Merge branch 'master' into TheLouisHong-PR-journal.lua-fix
ab9rf Jul 2, 2025
800ae83
Update changelog.txt
ab9rf Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ Template for new versions:
## New Features

## Fixes
- `gui/journal`: fix typo which caused the table of contents to always be regenerated even when not needed
- `gui/mod-manager`: gracefully handle mods with missing or broken ``info.txt`` files
- `uniform-unstick`: resolve overlap with new buttons in 51.13

Expand Down
2 changes: 1 addition & 1 deletion gui/journal.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ function JournalWindow:init()
self.subviews.table_of_contents_panel.visible = not collapsed
self.subviews.table_of_contents_divider.visible = not collapsed

if not colllapsed then
if not collapsed then
self:reloadTableOfContents()
end

Expand Down